search

cockroachdb / sequelize-cockroachdb

Use Sequelize and CockroachDB together
Apache License 2.0
53 stars 16 forks source link

Fix has many #73

Closed dougmrqs closed 3 years ago

dougmrqs commented 3 years ago

Rebased and reviewed tests. Substitutes #68.

dougmrqs commented 3 years ago

Do you know why a lot of tests from https://github.com/sequelize/sequelize/blob/main/test/integration/associations/has-many.test.js don't seem to be here?

Because they pass. I thought we would maintain only the broken ones to not have to keep a test suite of our own. We will trust Sequelize test suite. I've removed them in a commit, and I've been working this way, removing non-breaking tests. Does it make sense?