search

cockroachdb / terraform-provider-cockroach

Terraform provider for CockroachDB Cloud
Apache License 2.0
57 stars 12 forks source link

Send public network visibility when not private #112

Closed fantapop closed 1 year ago

fantapop commented 1 year ago

Previously on cluster creation, if the network_visibility was not explicitly set to private than, the unspecified or nil value was sent. This was problematic because Azure clusters require network_visibility of public to be passed.

Release Note: During cluster creation, explicitly send network_visibility of public if network_visibility of false is not set.

I'm not actually sure if this is what we want here. It doesn't appear that the CC API documents the default value of network_visibility.

Screenshot 2023-05-10 at 11 04 44 PM

One other option that could work instead of this change is to send the exact network visibility that is specified. For example, if it was set to private, we'd send private, if it was set to public we'd send public and if it wasn't specified we'd send not_specified.

Now that I'm thinking through this there is another option which is to coerce an unspecified value for azure to be network_visibility public inside the CCAPI.

erademacher commented 1 year ago

I think we landed on the same page, but to recap, please don't submit this. It'll break GCP, where the default is private.

jenngeorge commented 1 year ago

I think we landed on the same page, but to recap, please don't submit this. It'll break GCP, where the default is private.

Ah sorry I missed that! Removed my review.

fantapop commented 1 year ago

We converged on an alternate solution. Closing this one.