search

cockroachdb / terraform-provider-cockroach

Terraform provider for CockroachDB Cloud
Apache License 2.0
55 stars 10 forks source link

Add cluster checks to log and metric export resources #127

Closed jenngeorge closed 1 year ago

jenngeorge commented 1 year ago

Fix for https://github.com/cockroachdb/terraform-provider-cockroach/issues/117 Previously, log and metric export changes competed for the cluster lock and failed if it was not available. Now, they wait for the cluster lock's release before retrying. Read for these resources also now handles deleted clusters.

This change is Reviewable

jenngeorge commented 1 year ago

I'll undraft this after completing manual testing.

erademacher commented 1 year ago

We talked about this in app platform standup and decided that parsing the error body like this is fine. No HTTP status code maps directly to the concept of a locked cluster. Some get closer than "Bad Request", but aren't really worth the effort given that we're going to do a major error structure refactor at some point.

:shipit: