cockroachdb / terraform-provider-cockroach

Terraform provider for CockroachDB Cloud
Apache License 2.0
55 stars 10 forks source link

migrate testing framework to terraform-plugin-testing #185

Closed fantapop closed 3 months ago

fantapop commented 3 months ago

Previously, the terraform provider utilized the sdkv2 framework. In order to stay up to date with testing framework improvements we upgrade to the new terraform-plugin-testing framework following these instructions:

https://developer.hashicorp.com/terraform/plugin/testing/migrating

The change that instigated this upgrade is that the id field is no longer required in the new framework. During development of the role_grant_resource an ID was not used because the ccapi does not provide an ID for it. Rather than work around this using a synthetic ID, we upgrade.

Commit checklist

fantapop commented 3 months ago

@carloruiz / @andy-kimball as recent contributors to the terraform provider, I've added you two here as reviewers.

fantapop commented 3 months ago

The changes are separated into 2 commits, one with all the vendor changes. Don't let the 1600+ file counts scare you since its mostly vendor.