cockroachdb / terraform-provider-cockroach

Terraform provider for CockroachDB Cloud
Apache License 2.0
55 stars 10 forks source link

private endpoint services: support all clouds #189

Closed carloruiz closed 3 months ago

carloruiz commented 3 months ago

Previously, the private_endpoint_services resource only supported the creation of AWS private endpoint services. This commit removes this restriction, now all clouds are supported. Additionally this commit fixes a bug that caused the private_endpoint_service resource to be created without the resource state being loaded into the state file. Lastly, this commit bumps the CRDB version used for testing.

Commit checklist

carloruiz commented 3 months ago

acceptance test

COCKROACH_API_KEY=<key> COCKROACH_SERVER=https://management-staging.crdb.io make testacc 
TF_ACC=1 go test ./... -run TestAccDedicatedPrivateEndpointServicesResource -v  -timeout 40m -parallel 100
?       github.com/cockroachdb/terraform-provider-cockroach [no test files]
?       github.com/cockroachdb/terraform-provider-cockroach/mock    [no test files]
=== RUN   TestAccDedicatedPrivateEndpointServicesResource
=== PAUSE TestAccDedicatedPrivateEndpointServicesResource
=== CONT  TestAccDedicatedPrivateEndpointServicesResource
--- PASS: TestAccDedicatedPrivateEndpointServicesResource (1292.04s)
PASS
ok      github.com/cockroachdb/terraform-provider-cockroach/internal/provider   1292.485s
carloruiz commented 3 months ago

There were some failures in the acceptance tests ran against prod with the tag v1.3.2, so the release was not done.

This commit fixes the acceptance test failures and updates the CHANGELOG to include this PR's changes into the v1.3.2 release. Once this PR is merged, I will move the tag to the resulting SHA and restart the pre-release process.

Jira ticket with bug info CC-27459

carloruiz commented 3 months ago

TFTR!