ensure all test cluster names have tftest prefix

cockroachdb / terraform-provider-cockroach

Terraform provider for CockroachDB Cloud

Apache License 2.0

55 stars 10 forks source link

ensure all test cluster names have tftest prefix #196

Closed fantapop closed 3 months ago

fantapop commented 3 months ago

Prefixing the cluster names with "tftest" makes them easier to find in case they are failed to be cleaned up. Most were already prefixed that way. This change updates the remaining few that were not.

Commit checklist

[ ] Changelog
[ ] Doc gen (make generate)
[ ] Integration test(s)
[ ] Acceptance test(s)
[ ] Example(s)

fantapop commented 3 months ago

I was also thinking about something like that. @jaylim-crl are you fine with a tfTestPrefix variable instead of a function? I think its probably a similar amount of characters but easier to see at a glance whats going on.

jaylim-crl commented 3 months ago

I was also thinking about something like that. @jaylim-crl are you fine with a tfTestPrefix variable instead of a function? I think its probably a similar amount of characters but easier to see at a glance whats going on.

No strong preferences on that - either approaches are fine.