search

cockroachdb / terraform-provider-cockroach

Terraform provider for CockroachDB Cloud
Apache License 2.0
57 stars 12 forks source link

Audit error reporting #62

Closed erademacher closed 1 year ago

erademacher commented 1 year ago

Attempted to audit all calls to diagnostics.AddError to ensure that the error messages are accurate and follow a consistent formatting scheme, according to https://developer.hashicorp.com/terraform/plugin/log/writing. Standardized on "allowlist" instead of "allow list".

Also cleaned up some obsolete comments and validation checks.

Add a description of the problem this PR addresses and an overview of how this PR works.

This change is Reviewable

fantapop commented 1 year ago

internal/provider/networking_resource.go line 130 at r1 (raw file):

Previously, erademacher (Evan Rademacher) wrote…
It's the presence of a serverless config, not lack. This is a validation step, and in a future version, this will happen at plan time. That plan-time validation (and corresponding dry run) will happen way before we add these sorts of network tools to serverless clusters.

oh I see, this is in the creation of the allow list itself. Makes sense.

erademacher commented 1 year ago

TFTRs!