Support certificates rotation

cockroachlabs / visus

Extended performance metrics

Apache License 2.0

7 stars 3 forks source link

Support certificates rotation #94

Closed ihab-soliman-form3 closed 2 months ago

ihab-soliman-form3 commented 3 months ago

Cockroachdb support certificate rotation on sighup, can we have the same in visus on both the http server and the db connection. Proposed solution is to:

Update pgxpool to v5
Use the Reset function in the pool to close the connections without closing the pool
Set the tls config on both http server and the pool config to reload the certificate

I do have the changes ready but I can't seem to be able to push new a branch.

sravotto commented 3 months ago

Hi @ihab-soliman-form3, if you'd like to submit a change for review, please fork the repo into your github account, push the change to a branch on your own fork, then open a PR to the main branch on the this repository. I'll be happy to review your changes.

ihab-soliman-form3 commented 3 months ago

Thanks @sravotto, I am aware of that process 😄 just needed confirmation

ihab-soliman-form3 commented 3 months ago

@sravotto I also created this PR https://github.com/cockroachlabs/visus/pull/100