cockroachlabs / visus

Extended performance metrics
Apache License 2.0
7 stars 3 forks source link

Support certificates rotation #99

Closed ihab-soliman-form3 closed 2 months ago

ihab-soliman-form3 commented 3 months ago

Cockroachdb supports certificate rotation using sighup, visus does support sighup but it doesn't update the certificates used, the goal of this PR is to handle certificate rotation to be able to run visus as a sidecar with cockroachdb and both having the same process for certificate rotation.

Changes:

Closes https://github.com/cockroachlabs/visus/issues/94


This change is Reviewable

sravotto commented 3 months ago

Hi @ihab-soliman-form3, could you review and sign the Contributor License Agreement at https://cla.crdb.dev/cockroachlabs/visus ?

Thank you!

sravotto commented 2 months ago

@ihab-soliman-form3 thanks for the submission. However, in absence of a CLA we will be using #107 to implement the change requested.

Closing in favor of #107.

ihab-soliman-form3 commented 2 months ago

@sravotto thank you