search

cocktailpeanut / fluxgym

Dead simple FLUX LoRA training UI with LOW VRAM support
689 stars 44 forks source link

Fix text loading by skipping uploaded .txt files for resizing #54

Closed GavChap closed 2 days ago

GavChap commented 1 week ago

This fixed text file captioning by allowing text files to be uploaded, but they are skipped when resizing as they aren't an image.

cocktailpeanut commented 6 days ago

@GavChap Thanks for the PR. Could you explain why we need the extra lines 96-98 https://github.com/cocktailpeanut/fluxgym/pull/54/files#diff-568470d013cd12e4f388206520da39ab9a4e4c3c6b95846cbc281abc1ba3c959R96-R98

The line 90 already does the same thing and at first sight this feels redundant:

new_image_path = shutil.copy(image, destination_folder)

GavChap commented 6 days ago

@GavChap Thanks for the PR. Could you explain why we need the extra lines 96-98 https://github.com/cocktailpeanut/fluxgym/pull/54/files#diff-568470d013cd12e4f388206520da39ab9a4e4c3c6b95846cbc281abc1ba3c959R96-R98

The line 90 already does the same thing and at first sight this feels redundant:

new_image_path = shutil.copy(image, destination_folder)

Thanks, I just realised that all you need to do is a continue and skip the rest of the code in the loop if it's a .txt file, so I've updated to do that instead.