Download missing rmvpe.pt model, reorganize and reformat code with prettier, apply Javascript best practices - Githubissues

cocktailpeanut / rvc.pinokio

9 stars 1 forks source link

Download missing rmvpe.pt model, reorganize and reformat code with prettier, apply Javascript best practices #2

Open mdbouchard opened 4 months ago

mdbouchard commented 4 months ago

Fixes

Added missing download command for app/assets/rmvpe/rmvpe.pt.
- This fixed an error I saw during the Train > Feature extraction step.

Improvements

Grouped models under one list at the top of install.js.
Reorganized install.js, pinokio.js, and start.js leveraging modern Javascript best practices.
Ran prettier over all JS files to have a consistent coding style.

Manual Testing

Downloaded rvc.pinokio on Windows 11, started the app, and successfully trained a new voice.
Downloaded rvc.pinokio on MacOS with an M1 processor and successfully started the app.