coco / gitsup

View a GitHub project's issues sorted by thumbs up - down.
https://gitsup.herokuapp.com/isaacs/github
4 stars 1 forks source link

Strategy for managing GitHub API rate limits #10

Closed howardroark closed 8 years ago

howardroark commented 8 years ago

So the current github api as a rate limit that may prevent too much browsing. Need a strategy to deal with this.

Here is the API rate limit rules...

https://developer.github.com/v3/#rate-limiting

howardroark commented 8 years ago

For a start add a message to indicate that the rate limit has been reached.

mariosant commented 8 years ago

I figured out that the limit for non authenticated api calls are about 60 per hour, while authenticated calls can make up to 5000 per hour.

howardroark commented 8 years ago

So would that mean that after Oauth a token can be used to allow 5000? If so the solution is really just to say "Please sign in to browse more".

mariosant commented 8 years ago

Yup :)

Marios Antonoudiou
@marios_ant

On Mar 12 2016, at 7:18 pm, Howie <notifications@github.com> wrote:

So would that mean that after Oauth a token can be used to allow 5000? If so the solution is really just to say "Please sign in to browse more".


Reply to this email directly or view it on GitHub.

howardroark commented 8 years ago

This is complete on release in basic form. The strategy is in place never the less :)

mariosant commented 8 years ago

It's great to figure out how to do it! This should be added into the development branch once we move to components.

howardroark commented 8 years ago

Yeah, I'll post the commit for reference... https://github.com/gitsup/gitsup/commit/a9eb93bc17fcb99507e1977148012b4ba7dbbe90

Basically I just assume 403 status means rate limit.

Should we reopen?

mariosant commented 8 years ago

I guess we should, until this gets fixed in development.