search

coco / gitsup

View a GitHub project's issues sorted by thumbs up - down.
https://gitsup.herokuapp.com/isaacs/github
4 stars 1 forks source link

Add routes for issues and pr views. #11

Closed mariosant closed 8 years ago

howardroark commented 8 years ago

Can we have it all use the same view? Sort of assume that everything has the same schema and that it is more about filtering. The router can do the job of getting the schema ready and figuring out what is what.

user/repo = all user/repo/issues = issues user/repo/pulls = pulls

We could have another view that is for a 'detailed' summary.

Is that a meteor friendly option? Just keeps it more simple for dealing with UI :)

mariosant commented 8 years ago

Sure it is! Will modify the PR now.

mariosant commented 8 years ago

https://github.com/mariosant/gitsup/commit/9ac3714fad04c8e2f9160a1c7e27ffa7e8cea0d3 should do it @howardroark !

howardroark commented 8 years ago

Looks good! I do like the term project vs repo, makes more sense.

mariosant commented 8 years ago

I didn't really think about it! Are you sure it does?

On Sat, 12 Mar 2016 21:11 Howie, notifications@github.com wrote:

Looks good! I do like the term project vs repo, makes more sense.

— Reply to this email directly or view it on GitHub https://github.com/gitsup/gitsup/pull/11#issuecomment-195792857.

Marios Antonoudiou

howardroark commented 8 years ago

Hah! Yeah the project is sort of the whole thing. The repo is about the commits.