search

cocoabits / MASShortcut

Modern framework for managing global keyboard shortcuts compatible with Mac App Store. More details:
http://blog.shpakovski.com/2012/07/global-keyboard-shortcuts-in-cocoa.html
BSD 2-Clause "Simplified" License
1.52k stars 220 forks source link

Add a new initWithKeyUp initializer and corresponding sharedMonitorWithKeyUp to MASShortCutMonitor #111

Open yn5 opened 7 years ago

yn5 commented 7 years ago

Proposed solution for https://github.com/shpakovski/MASShortcut/issues/107. (Having a way to execute the event handler on key up as well).

I'd love some feedback on how to resolve the little code duplication caused by this pull request (and of course anything else that could improve the pull request).

yn5 commented 7 years ago

@zoul Would you mind taking a look at this pull request we discussed in https://github.com/shpakovski/MASShortcut/issues/107?