search

cocoabits / MASShortcut

Modern framework for managing global keyboard shortcuts compatible with Mac App Store. More details:
http://blog.shpakovski.com/2012/07/global-keyboard-shortcuts-in-cocoa.html
BSD 2-Clause "Simplified" License
1.52k stars 220 forks source link

Replace commas with semicolons to separate statements #116

Closed saagarjha closed 6 years ago

saagarjha commented 6 years ago

I've updated the code as suggested by Xcode 9; of particular note, there a couple of commas that should be semicolons.

shpakovski commented 6 years ago

@zoul Sorry, I did not mean it 🙂

zoul commented 6 years ago

Thank you! It would be much better to turn those commas into regular semicolons + newlines indeed. Can you just please limit the changes to that, leaving out the project changes?

saagarjha commented 6 years ago

Done. That's one warning gone at least; I would've preferred if you had taken the other changes as well but I guess that's something that we can apply locally.

zoul commented 6 years ago

Sorry about the remaining changes – I didn’t have enough time to go through them and I did not feel comfortable merging them automatically. Does Xcode warn you about something in the project? It compiles without warnings and analyzer results for me, Xcode 9.4 (9F1027a).

saagarjha commented 6 years ago

I’m getting a warning to add those changes. Nothing other than that, though.

zoul commented 6 years ago

Do you have an idea how to trigger the same warning on my side?

saagarjha commented 6 years ago

A fresh clone causes the warning to appear in Xcode 9.4.

zoul commented 6 years ago

Good tip, but it doesn’t work for me. I have noticed you have found the same problem in CocoaPods. Could there be something special in your Xcode? (We would be happy to fix the problem here anyway, I am just trying to reproduce it myself.)