search

cocoabits / MASShortcut

Modern framework for managing global keyboard shortcuts compatible with Mac App Store. More details:
http://blog.shpakovski.com/2012/07/global-keyboard-shortcuts-in-cocoa.html
BSD 2-Clause "Simplified" License
1.52k stars 220 forks source link

The Non-ARC version linked from README.md would appear to be sub par. #12

Closed heardrwt closed 11 years ago

heardrwt commented 11 years ago

For instance, it has a bunch of leaks, fails to call [super dealloc] from its dealloc methods and returns non auto-released objects from class methods that don't contain the words init / new.

I just pushed a much better example with Non-ARC / 32bit fixes to https://github.com/heardrwt/MASShortcut.

If people are looking for non-arc code, its likely they need it for 32bit support, so i also made sure it all compiles on 32bit.

shpakovski commented 11 years ago

Thanks a lot for your work! I added your repository to the README :)