search

cocoabits / MASShortcut

Modern framework for managing global keyboard shortcuts compatible with Mac App Store. More details:
http://blog.shpakovski.com/2012/07/global-keyboard-shortcuts-in-cocoa.html
BSD 2-Clause "Simplified" License
1.52k stars 220 forks source link

Updates for NSAppearance #123

Closed chockenberry closed 5 years ago

chockenberry commented 5 years ago

This is a simple change that lets MASShortcutView work better with NSAppearance changes in Mojave (10.14). Adding -allowsVibrancy lets the underlying NSButtonCell render correctly.

This change also modifies the demo app so it can test the various appearance scenarios. Because it relies on NSVisualEffectView to do this, its minimum deployment target is now 10.10.

I also modified the deployment targets in the framework to match this new requirement (previously it was 10.6). It's possible that you want the demo and framework to have different versions, so be careful merging this part. Personally, I think 10.10 is good minimum value - few people will be maintaining apps that don't use the appearance changes that were introduced in Yosemite.

shpakovski commented 5 years ago

Hi Craig, thanks a lot for the request. I like these changes and being at 10.14 it’s okay to flip the switch and go with 10.10 or 10.11 👍 There were some warnings in your branch though, and I fixed them. Could you please review my commit and confirm that it works for you? Thanks in advance!

shpakovski commented 5 years ago

Merged now, thanks again for your help.