cocoabits / MASShortcut

Modern framework for managing global keyboard shortcuts compatible with Mac App Store. More details:
http://blog.shpakovski.com/2012/07/global-keyboard-shortcuts-in-cocoa.html
BSD 2-Clause "Simplified" License
1.52k stars 220 forks source link

Use more specific types for -keyCode and -modifierFlags #128

Closed zoul closed 5 years ago

zoul commented 5 years ago

It was initially suggested in #103 that we change -keyCode to NSInteger and -modifierFlags to NSEventModifierFlags, but the changes were mixed with other unrelated stuff and the discussion died out. But the main point of the proposed patch was good, the suggested types make the code work better in Swift, apart from other things.