search

cocoabits / MASShortcut

Modern framework for managing global keyboard shortcuts compatible with Mac App Store. More details:
http://blog.shpakovski.com/2012/07/global-keyboard-shortcuts-in-cocoa.html
BSD 2-Clause "Simplified" License
1.52k stars 220 forks source link

Multiple Warnings for Deprecations #154

Closed JasonAnytune closed 3 years ago

JasonAnytune commented 3 years ago

Code has warnings with deprecations as follows:

/Pods/MASShortcut/Framework/Model/MASShortcutValidator.m:34:42: 'NSCommandKeyMask' is deprecated: first deprecated in macOS 10.12
/Pods/MASShortcut/Framework/Model/MASShortcutValidator.m:35:42: 'NSControlKeyMask' is deprecated: first deprecated in macOS 10.12
/Pods/MASShortcut/Framework/Model/MASShortcutValidator.m:39:41: 'NSAlternateKeyMask' is deprecated: first deprecated in macOS 10.12
/Pods/MASShortcut/Framework/Model/MASShortcutValidator.m:67:86: 'NSShiftKeyMask' is deprecated: first deprecated in macOS 10.12
/Pods/MASShortcut/Framework/Model/MASShortcut.m:189:30: 'NSControlKeyMask' is deprecated: first deprecated in macOS 10.12
/Pods/MASShortcut/Framework/Model/MASShortcut.m:190:30: 'NSAlternateKeyMask' is deprecated: first deprecated in macOS 10.12
/Pods/MASShortcut/Framework/Model/MASShortcut.m:191:30: 'NSShiftKeyMask' is deprecated: first deprecated in macOS 10.12
/Pods/MASShortcut/Framework/Model/MASShortcut.m:192:30: 'NSCommandKeyMask' is deprecated: first deprecated in macOS 10.12
/Pods/MASShortcut/Framework/UI/MASShortcutView.m:234:74: 'NSRightTextAlignment' is deprecated: first deprecated in macOS 10.12
/Pods/MASShortcut/Framework/UI/MASShortcutView.m:245:65: 'NSCenterTextAlignment' is deprecated: first deprecated in macOS 10.12
/Pods/MASShortcut/Framework/UI/MASShortcutView.m:250:110: 'NSRightTextAlignment' is deprecated: first deprecated in macOS 10.12
/Pods/MASShortcut/Framework/UI/MASShortcutView.m:259:69: 'NSCenterTextAlignment' is deprecated: first deprecated in macOS 10.12
/Pods/MASShortcut/Framework/UI/MASShortcutView.m:264:30: 'NSCenterTextAlignment' is deprecated: first deprecated in macOS 10.12
/Pods/MASShortcut/Framework/UI/MASShortcutView.m:437:34: 'NSKeyDownMask' is deprecated: first deprecated in macOS 10.12
/Pods/MASShortcut/Framework/UI/MASShortcutView.m:437:50: 'NSFlagsChangedMask' is deprecated: first deprecated in macOS 10.12
/Pods/MASShortcut/Framework/UI/MASShortcutView.m:462:49: 'NSCommandKeyMask' is deprecated: first deprecated in macOS 10.12
/Pods/MASShortcut/Framework/UI/MASShortcutView.m:479:48: 'NSCriticalAlertStyle' is deprecated: first deprecated in macOS 10.12
shpakovski commented 3 years ago

Hi @JasonAnytune, thanks for the report! Would you like to make a pull request?

JasonAnytune commented 3 years ago

Yes, let me know what's involved

nevack commented 3 years ago

I see some other issues. image

Recommended settings migration by Xcode 12.4 image

JasonAnytune commented 3 years ago

Will the change in "Apply Xcode recommended settings" clear these warnings? If so, the version number needs to be updated since I am installing with cocoa-pods and there is no change noticed.

shpakovski commented 3 years ago

@JasonAnytune Indeed, thanks for the report!

JasonAnytune commented 3 years ago

Thanks for the fix and valuable software!