Open sfsam opened 3 years ago
same here, then updating it to the /include/module.modulemap path results in all sorts of header files not being found... couldn't figure out how to fix it.
same here, don't know how to fix it.
Hey, friends. After checking the git commits, I figure out that this problem caused by these two commits(1 and 2 in pic). You can checkout this commit ( 3 in pic ) temporarily.
👍🏻
There are several thing wrong with .xcodeproj now and I could not fix it either.
.modulemap and MASShortcutViewButtonCell are missing from the project
project won’t compile because it can no longer find some headers
MASLocalization.m should use conditional complication:
localizationBundle = SWIFTPM_MODULE_BUNDLE;
// old code
Also README.md SwiftPM instruction links to wrong repo
cc: @sweetppro, @shpakovski
@pointum this should (hopefully) be fixed in this pull request: https://github.com/shpakovski/MASShortcut/pull/162
@sweetppro some files and headers still got unresolved. I’ve created a new PR #166. Thank you for implementing SwiftPM. I’m going to use it but wanted to fix the project first anyway.
@pointum nice one! I don't use Cocoa Pods or Carthage so weren't seeing any of the build errors. Ill close my PR
@sweetppro I don’t use those either. Just a direct .xcodeproj dependency. It did not build even when I open standalone MASShortcut.xcodeproj
and try to build MASShortcut
framework or Demo
app targets.
@pointum ah weird, It compiles fine for me when added directly to a project via SPM. well, for what its worth. I hope everything is fine for all situations now :)
Getting an error when trying to build with either Xcode or the Makefile.
Makefile output:
error: missing module map file: '/Users/xxxx/Dev/macOS/MASShortcut/Framework/MASShortcut.modulemap (in target 'MASShortcut' from project 'MASShortcut')
Xcode output:
Xcode project navigator:
I think this happened after the recent SPM updates. I'd try to fix myself, but unfortunately I hardly know anything about Swift or SPM.