cocoabits / MASShortcut

Modern framework for managing global keyboard shortcuts compatible with Mac App Store. More details:
http://blog.shpakovski.com/2012/07/global-keyboard-shortcuts-in-cocoa.html
BSD 2-Clause "Simplified" License
1.52k stars 220 forks source link

Getting 'Error: missing module map file' when trying to build #164

Open sfsam opened 3 years ago

sfsam commented 3 years ago

Getting an error when trying to build with either Xcode or the Makefile.

Makefile output: error: missing module map file: '/Users/xxxx/Dev/macOS/MASShortcut/Framework/MASShortcut.modulemap (in target 'MASShortcut' from project 'MASShortcut')

Xcode output: CleanShot 2021-07-05 at 11 33 48@2x

Xcode project navigator:

Screen Shot 2021-07-05 at 11 31 59 AM

I think this happened after the recent SPM updates. I'd try to fix myself, but unfortunately I hardly know anything about Swift or SPM.

eternalstorms commented 3 years ago

same here, then updating it to the /include/module.modulemap path results in all sorts of header files not being found... couldn't figure out how to fix it.

sz-zdy commented 3 years ago

same here, don't know how to fix it.

sz-zdy commented 3 years ago

Hey, friends. After checking the git commits, I figure out that this problem caused by these two commits(1 and 2 in pic). You can checkout this commit ( 3 in pic ) temporarily. image

eternalstorms commented 3 years ago

👍🏻

pointum commented 3 years ago

There are several thing wrong with .xcodeproj now and I could not fix it either.

cc: @sweetppro, @shpakovski

sweetppro commented 3 years ago

@pointum this should (hopefully) be fixed in this pull request: https://github.com/shpakovski/MASShortcut/pull/162

pointum commented 3 years ago

@sweetppro some files and headers still got unresolved. I’ve created a new PR #166. Thank you for implementing SwiftPM. I’m going to use it but wanted to fix the project first anyway.

sweetppro commented 3 years ago

@pointum nice one! I don't use Cocoa Pods or Carthage so weren't seeing any of the build errors. Ill close my PR

pointum commented 3 years ago

@sweetppro I don’t use those either. Just a direct .xcodeproj dependency. It did not build even when I open standalone MASShortcut.xcodeproj and try to build MASShortcut framework or Demo app targets.

sweetppro commented 3 years ago

@pointum ah weird, It compiles fine for me when added directly to a project via SPM. well, for what its worth. I hope everything is fine for all situations now :)