search

cocoabits / MASShortcut

Modern framework for managing global keyboard shortcuts compatible with Mac App Store. More details:
http://blog.shpakovski.com/2012/07/global-keyboard-shortcuts-in-cocoa.html
BSD 2-Clause "Simplified" License
1.52k stars 220 forks source link

Fix `'MASShortcut/MASKeyCodes.h' file not found` error #177

Closed dnicolson closed 2 years ago

dnicolson commented 2 years ago

This pull request fixes a 'MASShortcut/MASKeyCodes.h' file not found build error on macOS 12.3.1 (21E258) with Xcode 13.3.1 (13E500a) by reverting https://github.com/shpakovski/MASShortcut/pull/176. There doesn't seem to be a way to reproduce https://github.com/shpakovski/MASShortcut/issues/172.

The error occurs with these steps:

  1. Create a new macOS app project
  2. Add package MASShortcut against branch master (031e561ce89b23c904feece009a377b17c27c8fa)

Interestingly, the issue doesn't occur when creating a new multiplatform app project, this could have something to do with the directory structure being different. For multiplatform projects, there are macOS and Shared directories instead of one directory named after the project.

The issue also occurs on macOS 13.0 Beta (22A5295i) with Xcode 14.0 beta 3 (14A5270f), but the difference here is that the directory structure is the same for Mac and multiplatform projects (the red label indicates the build error).

PixelSnap 2022-07-24 at 23 46 14@2x

shpakovski commented 2 years ago

@dnicolson Sorry for inconvenience and thank you for the fix.