search

cocoabits / MASShortcut

Modern framework for managing global keyboard shortcuts compatible with Mac App Store. More details:
http://blog.shpakovski.com/2012/07/global-keyboard-shortcuts-in-cocoa.html
BSD 2-Clause "Simplified" License
1.52k stars 220 forks source link

Added utility method to unregister all global shortcuts that are current... #27

Closed daniel-beard closed 10 years ago

daniel-beard commented 11 years ago

...ly registered.

shpakovski commented 11 years ago

Hello Daniel, thank you for the pull request. I believe the method you are adding should have a name like removeAllGlobalShortcutsFromUserDefaults. The thing is that setGlobalShortcut:nil and unregisterGlobalShortcutWithUserDefaultsKey:nil lead to different results. The former method will remove the shortcut from the user defaults, while the latter will stop listening to the hotkey press. Could you please be more specific? Maybe you needed unregisterGlobalShortcutWithUserDefaultsKey:key instead of setGlobalShortcut:nil?

daniel-beard commented 11 years ago

You're right, that was my intention. I'll update this tonight.

shpakovski commented 11 years ago

Hey Daniel, any update on this?