search

cocoabits / MASShortcut

Modern framework for managing global keyboard shortcuts compatible with Mac App Store. More details:
http://blog.shpakovski.com/2012/07/global-keyboard-shortcuts-in-cocoa.html
BSD 2-Clause "Simplified" License
1.52k stars 220 forks source link

Replace deprecated NSRunCriticalAlertPanel with NSAlert #35

Closed ShadowLightz closed 10 years ago

ShadowLightz commented 10 years ago

Motivation for this was the string literal warning, which was resolved by iluuu1994. But I noticed that the API was deprecated so ported it to new NSAlert. I decided to show as a sheet because the failure is very focused to a specific preferences window. NSCriticalAlertStyle was according to Apple's docs not appropriated. They designed it for really critical things, "for example, a “clean install” will erase all data on a volume".

shpakovski commented 10 years ago

Sounds great, thank you for the pull request!