cocoabits / MASShortcut

Modern framework for managing global keyboard shortcuts compatible with Mac App Store. More details:
http://blog.shpakovski.com/2012/07/global-keyboard-shortcuts-in-cocoa.html
BSD 2-Clause "Simplified" License
1.52k stars 220 forks source link

Shortcut validation doesn’t consider different keyboard layouts #62

Open zoul opened 9 years ago

zoul commented 9 years ago

Test case: Using the US keyboard layout, assign the ^2 shortcut to a menu item and switch to the Czech keyboard layout. Now trying to record a shortcut will pass the validation, although the shortcuts have the same key code and modifiers and are in conflict. See #60 for previous discussion. No idea if we can handle this better, but at least we could describe the failing case in the spec and the docs.