search

cocoabits / MASShortcut

Modern framework for managing global keyboard shortcuts compatible with Mac App Store. More details:
http://blog.shpakovski.com/2012/07/global-keyboard-shortcuts-in-cocoa.html
BSD 2-Clause "Simplified" License
1.52k stars 220 forks source link

Support installation with Carthage #67

Closed brow closed 9 years ago

brow commented 9 years ago

I use Carthage to check out my dependencies and build them as dynamic frameworks.

This tweaks the framework target to make it build with xcodebuild and export a MASShortcut module that can be imported from Swift.

It also adds a Carthage badge to the README, but that's not important and can be reverted if you like.

Thanks for MASShortcut!

shpakovski commented 9 years ago

Thank you, this is awesome :)

zoul commented 9 years ago

Great, thank you. (Didn’t know Carthage, will check it out.) Just a nit: More descriptive commit logs would be nice next time. „Module map“ doesn’t say much outside the context of the pull request.

brow commented 9 years ago

@zoul Fair enough. I'll be sure to do that next time. Thanks for the quick review!