Stop working after registering the same input after cancellation

[hatashiro]

First of all, thanks for this great job. It really saves a whole lot of my time.

I found a bug that a shortcut stops working after registering the same shortcut as before after cancelling it. This occurs in the demo app too.

Steps to Reproduce

• Register a shortcut, let me say it's cmd+j.
• Cancel the shortcut
• Register the same shortcut, cmd+j.
• And then the shortcut stops working.

Is there any documentation I missed or is this a bug?

Thanks in advance.

[hatashiro]

Just found a workaround like below, but not quite sure if it's rightly done.

// swift
func shortcutValueDidChanged(sender: MASShortcutView!) {
    if sender.shortcutValue == nil {
        resetShortcutBinder()
    }
}

func resetShortcutBinder() {
    MASShortcutBinder.sharedBinder().breakBindingWithDefaultsKey(shortcutKey!)
    MASShortcutBinder.sharedBinder().bindShortcutWithDefaultsKey(shortcutKey!, toAction: selectInput)
}

[shpakovski]

@zoul Hey Tom, I'm calling for help 😆 Maybe some cleanup needed?

[zoul]

I’m currently offline, will take a look at the issue on Sunday or next week. Since the bug is reproducible, it should be easy to fix.

[vityevato]

I think this #71

[shpakovski]

@noraesae Could you please verify the fix? Thanks in advance.

[hatashiro]

I've tested the patch and it works like a charm. Thanks!

[shpakovski]

Thank you all guys!