search

cocoabits / MASShortcut

Modern framework for managing global keyboard shortcuts compatible with Mac App Store. More details:
http://blog.shpakovski.com/2012/07/global-keyboard-shortcuts-in-cocoa.html
BSD 2-Clause "Simplified" License
1.52k stars 220 forks source link

fixes localized strings when using CocoaPods #75

Closed beaufour closed 8 years ago

beaufour commented 8 years ago

Puts strings inside a MASShortcut resource bundle, and looks for locallized strings inside that bundle when used as a CocoaPod.

I tested this is a new vanilla project using CocoaPods and my local repo.

Fixes the issue I raised in #74.

zoul commented 8 years ago

Perfect, thanks! The #ifdef is a bit ugly, but I guess we can live with it. (Or can you think of a better solution? I hate to have CocoaPods-specific stuff directly in the code.) Will release an update tomorrow.

beaufour commented 8 years ago

Perfect, thanks! The #ifdef is a bit ugly, but I guess we can live with it. (Or can you think of a better solution? I hate to have CocoaPods-specific stuff directly in the code.)

Yeah, it is not the pretties thing, but something needs to select the other bundle. Alternatively the code could check for the presence of the bundle and use it if it finds it?