search

cocoabits / MASShortcut

Modern framework for managing global keyboard shortcuts compatible with Mac App Store. More details:
http://blog.shpakovski.com/2012/07/global-keyboard-shortcuts-in-cocoa.html
BSD 2-Clause "Simplified" License
1.52k stars 220 forks source link

Another approach to try a fix for the CocoaPods localization bundle problem (#74). #78

Closed nivanchikov closed 8 years ago

nivanchikov commented 8 years ago

Checking if resources bundle was copied inside framework bundle, then falling back to old search methods

shpakovski commented 8 years ago

Thanks, anyone using a project with CocoaPods can verify please? 🙃

zoul commented 8 years ago

The current HEAD detection code doesn’t work? (Introduced as an experiment in 5a18ccc.)

ashokgelal commented 8 years ago

The head (7fc5e78) working fine for me. No X's anymore.

zoul commented 8 years ago

Merged in d32fc18, thank you for the contribution and sorry for the long delay!

nivanchikov commented 8 years ago

@zoul thx, I suppose "Caveats" section from this article can shed some light on the choice of [NSBundle bundleForClass:] method for Swift frameworks: https://blog.cocoapods.org/CocoaPods-0.36/