cocoabits / MASShortcut

Modern framework for managing global keyboard shortcuts compatible with Mac App Store. More details:
http://blog.shpakovski.com/2012/07/global-keyboard-shortcuts-in-cocoa.html
BSD 2-Clause "Simplified" License
1.52k stars 220 forks source link

Why don’t we allow shortcuts with Shift and Alt modifiers? #79

Closed zoul closed 8 years ago

zoul commented 8 years ago

Recently I have found that MASShortcut doesn’t record shortcuts such as Shift-Alt-U. The reason is in the validation logic in MASShortcutValidator. I can understand why we disallow Alt-something, but shouldn’t Shift-Alt-something work? @shpakovski, do you have an idea why Shift-Alt-something is not considered valid? Thanks!

shpakovski commented 8 years ago

@zoul I did not want to encourage these shortcuts because Shift-Option works just like Option. For example, Shift-Option-K = .

UPD There is a property allowAnyShortcutWithOptionModifier by the way, have you enabled it?

zoul commented 8 years ago

Makes sense, thank you! (I will document the behaviour so that people know the thinking behind it.) I noticed the allowAny… switch, but I wasn’t sure what the exact deal was, what were the potential drawbacks, so I didn’t touch it. I’ll leave the issue open as a reminder to update the docs.

shpakovski commented 8 years ago

Cool, thanks!

SenorSamuel commented 4 years ago

that's really cool