select some changed files -> Review & Commit

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Open some local copy of repo from Working copies
2. Select some objects
3. Right mouse button -> Review & Commit

What is the expected output? What do you see instead?
Expected: only selected files placed for review and commit.
Seen: all files which were changed

What version of the product are you using? On what operating system?
MacOSX 10.6.3.
svnX 1.3 final.

Please provide any additional information below.
Nothing.

Original issue reported on code.google.com by TheLe...@gmail.com on 2 Nov 2010 at 12:42

[GoogleCodeExporter]

You shouldn't expect this behaviour as it has never been that way.

If, however, you are requesting an option to initially only tick (check) the 
currently selected items when opening a Review & Commit window.  Then I will 
consider adding a preference for that.

Note: A major point of Review & Commit windows is that they allow you to change 
the selection independently of the items chosen for commit.  Thus they list 
all/only committable items & have a separate checkbox column.
The WC window’s Commit command allows you to simply commit the currently 
selected items.

Original comment by chris...@gmail.com on 2 Nov 2010 at 4:41

[GoogleCodeExporter]

I couldn't see any big logical differences between "Commit" and "Review and 
Commit".
So, I think this doesn't sound intuitive as for me:
Note: A major point of Review & Commit windows is that they allow you to change 
the selection independently of the items chosen for commit.  Thus they list 
all/only committable items & have a separate checkbox column.

Original comment by TheLe...@gmail.com on 2 Nov 2010 at 9:04

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

I don't understand what you are saying.
Please explain.
Do you not understand how "Commit" and "Review and Commit" differ?
What exactly "doesn't sound intuitive" to you?  Do you require a fuller 
explanation?
Have you reviewed the help document?

Original comment by chris...@gmail.com on 5 Nov 2010 at 2:32

[GoogleCodeExporter]

For me logical is:
1) Commit - select elements and by "Commit" add a message and than commit to 
repo.
2) Commit and review nothing selected(at start by default) - all elements are 
shown after clicking "Commit and Review". Now it's selecting first element, 
which I think is kinda wrong.
3) Commit and review some files selected(manually by user!) - only selected 
elements are shown after clicking "Commit and Review". For example I know that 
I need to commit only this files, but I am not 100% sure that I haven't done 
something incorrect inside one of them. Now I logically select some number of 
files -> open "Commit and Review" window. Than at new window I should filter 
again which one I need by checkboxes. Something looks wrong here. I 
select\filter two times what I need to commit.

It's maybe also a good idea to review all(show all elements at "Commit and 
review") but to select only selected previously. I think this would be the best 
because I might want to select one more file after review.

Original comment by TheLe...@gmail.com on 5 Nov 2010 at 7:18

[GoogleCodeExporter]

It's maybe also a good idea to review all(show all elements at "Commit and 
review") but to select(check with checkboxes) only selected previously. I think 
this would be the best because I might want to select(check with checkboxes) 
one more file after reviewing of files I have checked already.

Original comment by TheLe...@gmail.com on 5 Nov 2010 at 7:22

[GoogleCodeExporter]

Original comment by chris...@gmail.com on 14 Apr 2011 at 1:04

• Added labels: Priority-Low, Type-Enhancement
• Removed labels: Priority-Medium, Type-Defect