Removing color codes - Githubissues

cocodelabs / znc-palaver

ZNC module for push notifications

MIT License

112 stars 14 forks source link

Removing color codes #14

Closed terokorp closed 10 years ago

terokorp commented 10 years ago

When hilighted message has color codes, push notification dosen't work at all. This is realy annoying when using IRC gateway like CraftIRC and it put colorcodes automaticly to every message.

This is not best way to do it (just hotfix), but does job.

sMessage: '<[G]\x0300[\x0309言葉0o\x0300]\x0FPlayer>\x0F nickname, will this work?' that message didin't work without this fix.

kylef commented 10 years ago

Thanks for your patch @tkorpe. As you said "this is not the best way to do it", so I have made a better patch and committed it. Instead I used a new API introduced in ZNC 1.2 to strip a message of control characters.

There are a couple of issues with your implementation:

It changes a reference to the sMessage, therefor it will strip the message going to all other modules and potentially to the client.
Missed control characters such as bold, reverse, italics, underline.

terokorp commented 10 years ago

yea, as I said it was just hotfix to get it to work somehow with irc gateway. I use that unitil get better and wanted to share it if someone have same problem.