cocodelabs / znc-palaver

ZNC module for push notifications
MIT License
112 stars 14 forks source link

Support ZNC 1.6.0 #20

Closed MarcusHogue closed 9 years ago

MarcusHogue commented 9 years ago

I'm trying to compile the module on OS X for ZNC 1.6 and getting the following errors with it failing to compile:

/usr/local/Cellar/znc/1.6.0/include/znc/ZNCString.h:85:47: error: expected a class or namespace
        static const CaseSensitivity CaseSensitive = CaseSensitivity::CaseSensitive;
                                                     ^
/usr/local/Cellar/znc/1.6.0/include/znc/ZNCString.h:86:49: error: expected a class or namespace
        static const CaseSensitivity CaseInsensitive = CaseSensitivity::CaseInsensitive;
                                                       ^
kylef commented 9 years ago

Hi @MarcusHogue,

Thanks for reporting, this seems like a bug in ZNC itself. I'm going to try hunt it down and fix it.

lvialle commented 9 years ago

In order to compile, you need to edit ZNCString.h from your ZNC installation and change lines 85-86 to: static const CaseSensitivity CaseSensitive = CaseSensitive; static const CaseSensitivity CaseInsensitive = CaseInsensitive;

https://github.com/znc/znc/blob/master/include/znc/ZNCString.h#L85-L86

bradleysepos commented 9 years ago

cocodelabs/znc-palaver@f159c78 (latest) and znc/znc@f47e846 (1.6.0) appear to build without modifications on OS X 10.10.4 / Xcode 6.4. Suggest closing this issue.

kylef commented 9 years ago

Thanks @bradleysepos