cocodelabs / znc-palaver

ZNC module for push notifications
MIT License
112 stars 14 forks source link

Not working in 2.2? #28

Closed FryDay closed 8 years ago

FryDay commented 8 years ago

This module seems to be having issues with Palaver 2.2. The client never seems to receive push notifications. My same ZNC installation was working fine pre 2.2.

kylef commented 8 years ago

@FryDay Can you include a bit of information:

FryDay commented 8 years ago

ZNC 1.6.1

Latest version of the module from git. (I am also using clientaway and verified that my nick is away before testing).

Info: Palaver ZNC: d0a8db1 Current device: (long string of characters) 2 registered devices (my wife and I both use it).

Let me know if you need anything else.

kylef commented 8 years ago

@FryDay Does the following send you a push notification.

From a different client while Palaver is not connected and in the background:

/msg *palaver test
FryDay commented 8 years ago

It does not. It says "Notification sent to 1 clients." but nothing is received.

emagaliff commented 8 years ago

@kylef Same issue as @FryDay . No test notification received but said it sent.

Was not working before 2.2 update either

Palaver 2.2 / ZNC 1.6.1

kylef commented 8 years ago

@emagaliff Can you make sure that you have the latest version of the module and show the output of /msg *palaver info.

@FryDay Can you try going into "iOS setting app -> Palaver > Notifications" and toggle "Allow Notifications off and on and then go back into Palaver. See if this solves your problem.

FryDay commented 8 years ago

@kylef Didn't work.

So it worked fine on my iPhone 5s with the last version of Palaver. Got my iPhone 6s and the updated version of Palaver and push doesn't work. I doubt the change in iPhone would have any effect, so I have to assume it's an issue with 2.2.

I even tried rebuilding the znc module, uninstalling and reinstalling the app, notifications off and on...nothing seems to fix it.

FryDay commented 8 years ago

@kylef Found something that might be relevent. On the wiki, it says: Notifications will only be sent if all your clients are disconnected, or marked as away.

If I run a list right now, I see this:

* REMOVED FOR SECURITY REASON *

When do these get cleaned up? Could there be a conflict of some sort?

badloop commented 8 years ago

@FryDay the test should still send a push notification to palaver even if you're not marked as away. Just tested this on my iPhone 6 with znc 1.7.x

FryDay commented 8 years ago

@aarondunlap And your push notifications are working as well? I feel like I shouldn't have two separate users with identical device numbers. It doesn't appear like there is a way to unregister a device, though.

If it's working for you, maybe I'll try rebuilding znc.

emagaliff commented 8 years ago

@kylef Just rebuilt the module from the latest github source. Output:

[11:14:13] <*palaver> Palaver ZNC: unknown -- http://palaverapp.com/ [11:14:13] <*palaver> 1 registered devices [11:14:13] <*status> ZNC 1.6.1 - http://znc.in [11:14:13] <*status> IPv6: yes, SSL: yes, DNS: threads, charset: yes

When I do the same from Palaver, it also shows my current device with ID.

kylef commented 8 years ago

Hi everyone. This thread is a bit hard to follow with three people latching on with separate problems.

Can anyone who is still having problems move to email (support@palaverapp.com) or hit me up on Freenode (kylef).

Steps to confirm

NOTE: Do NOT share tokens from /msg *palaver info and /msg *palaver list anywhere but privately with support@palaverapp.com. These are private access tokens and should not be shared with anyone.

Debugging Steps

My Device is not registered when I use /msg *palaver info from the device.

Please go into Palaver's settings and then tap "System Settings" followed by "Notifications" and toggle "Allow Notifications" off and on and then go back into the app and try /msg *palaver info again.

My Device is registered and /msg *palaver test is not showing the notification.

This is a tricky problem and can be due to a bug in older versions of OpenSSL. The only way to dig into this one further is to run ZNC in debug mode (znc --debug) and look at the output produced when you run /msg *palaver test. The output should include the exact reason for the push notification failure. You can send me the output for analysis.


Note the output of /msg *palaver list is for debugging purposes, and old stale devices are not a problem and will be cleaned up on their own in the future.

kylef commented 8 years ago

I've also added some other reasons for failings inside the README.