search

coconut-svsm / svsm

COCONUT-SVSM
MIT License
123 stars 43 forks source link

docs: Document management of allocation operations and memory regions #243

Closed Zildj1an closed 9 months ago

Zildj1an commented 10 months ago

Document memory management of (de)allocation operations and its related testing functions, and memory regions handling. This is related to issue #74 Document COCONUT-SVSM.

Zildj1an commented 10 months ago

Thanks for reviewing @00xc I have applied all your suggestions

Zildj1an commented 9 months ago

Just added a commit documenting the memory regions

Zildj1an commented 9 months ago

Thanks @00xc for your review, I have rebased and applied feedback

Zildj1an commented 9 months ago

I'm getting the following error, I'm unsure it's related to my changes: 

 error: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
   --> igvmbuilder/src/ovmf_firmware.rs:193:11
    |
193 |     data: &Vec<u8>,
    |           ^^^^^^^^ help: change this to: `&[u8]`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
    = note: `-D clippy::ptr-arg` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::ptr_arg)]`

error: could not compile `igvmbuilder` (bin "igvmbuilder") due to 1 previous error
00xc commented 9 months ago

I'm getting the following error, I'm unsure it's related to my changes:

 error: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
   --> igvmbuilder/src/ovmf_firmware.rs:193:11
    |
193 |     data: &Vec<u8>,
    |           ^^^^^^^^ help: change this to: `&[u8]`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
    = note: `-D clippy::ptr-arg` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::ptr_arg)]`

error: could not compile `igvmbuilder` (bin "igvmbuilder") due to 1 previous error

Please rebase on the updated main branch, I think that should fix it.

Zildj1an commented 9 months ago

I'm getting the following error, I'm unsure it's related to my changes:

 error: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
   --> igvmbuilder/src/ovmf_firmware.rs:193:11
    |
193 |     data: &Vec<u8>,
    |           ^^^^^^^^ help: change this to: `&[u8]`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
    = note: `-D clippy::ptr-arg` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::ptr_arg)]`

error: could not compile `igvmbuilder` (bin "igvmbuilder") due to 1 previous error

Please rebase on the updated main branch, I think that should fix it.

Thanks @00xc looks like we're good now