search

coconut-svsm / svsm

COCONUT-SVSM
MIT License
113 stars 39 forks source link

tpm: Remove need for libssl build dependency #458

Closed AdamCDunlap closed 1 week ago

AdamCDunlap commented 2 weeks ago

Coconut-SVSM vendors its own copy of openssl (via git submodule), but previously it didn't pass in the right variables to libmstpm's configure script to tell it to use it. This meant that libssl-dev must be installed on the build system in order to build Coconut.

This can be bypassed by passing LIBCRYPTO_LIBS and LIBCRYPTO_CFLAGS to configure. Coconut-SVSM was previously passing in LIBCRYPTO_LIBS only, but it would double-expanding the variables meaning that it was actually passing LIBCRYPTO_LIBS="", which was not enough for configure. Fix this, and also pass LIBCRYPTO_CFLAGS so that configure realizes the libcrypto dependency is satisfied without needing it installed on the build system.

Tested by building in a docker container based on debian12 without libssl-dev.

This commit also modifies the documentation and github workers to remove this dependency, but I have no way of directly testing these.

deeglaze commented 2 weeks ago

Hurray!

stefano-garzarella commented 2 weeks ago

@AdamCDunlap cool, thanks for that!

Can we also remove libopenssl-devel from scripts/container/opensuse-rust.docker ?

AdamCDunlap commented 2 weeks ago

@AdamCDunlap cool, thanks for that!

Can we also remove libopenssl-devel from scripts/container/opensuscrpits/conse-rust.docker ?

Pushed a new version with that change. Thanks for taking a look.

stefano-garzarella commented 1 week ago

@AdamCDunlap cool, thanks for that! Can we also remove libopenssl-devel from scripts/container/opensuscrpits/conse-rust.docker ?

Pushed a new version with that change. Thanks for taking a look.

Thanks! While testing, I found some issue with the container build, so just opened this: https://github.com/coconut-svsm/svsm/pull/468