feat: autodetect an ADB device when no vendor or product ID is specified

cocool97 / adb_client

Rust ADB (Android Debug Bridge) client library

MIT License

144 stars 23 forks source link

Closed lavafroth closed 2 weeks ago

lavafroth commented 2 weeks ago

Added methods autodetect to autodetect_with_custom_private_key to ADBUSBDevice
Added private functions to check if a usb device has the signature of an ADB device
Made the vendor_id and product_id USB arguments optional and default to aforementioned methods

lavafroth commented 2 weeks ago

I will make the necessary changes in a day's worth of time. Thanks again for the review :D

cocool97 commented 2 weeks ago

I cleaned the code a bit with functions that could be called either with a custom private key or not.

I also remove the thread(s) spawned to get devices, if no device is find at the time an error is raised

lavafroth commented 2 weeks ago

Thank you very much! I like that you are explicitly refusing to handle multiple devices under autodetect. Makes sense.

Should we expose the search_adb_devices function or something similar that allows the user to query all matching VIDs and PIDs?

cocool97 commented 2 weeks ago

I think we can keep it private for now and see if there are people needing it

lavafroth commented 2 weeks ago

good call