Open NutchapolSal opened 1 week ago
This should definitely be the case, I'll have a deeper look at it this week. Crate is evolving nowadays, I'm not against breaking changes. We can also add a framebuffer_bytes()
method to prevent breaking. I'll consider it
(in the same spirit of changing
shell()
) I thinkADBServerDevice.framebuffer()
should returnRgbaImage
directly, so if some code needs to use the image right after, they wouldn't have to re-read the image from disk, or they can choose to save the image later. My personal project have been usingframebuffer_inner()
by compiling with a locally modified copy of your code (adding a singlepub
keyword), and everything seems to be fine.This would probably require moving a little bit of stuff into
adb_cli
Renaming or changingADBServerDevice.framebuffer()
's outputs would be a breaking change, so maybe deprecate that one and make a new public method?