cocopon / vaffle.vim

:file_folder: Lightweight, window-based file manager for Vim
MIT License
284 stars 20 forks source link

Add <Plug>(vaffle-chdir-current) #12

Closed ichizok closed 6 years ago

ichizok commented 6 years ago

I want a simple way to change the current directory to the path vaffle buffer shows :)

cocopon commented 6 years ago

Thank you for the pull request!

I think the feature is nice, but need to consider its name. Maybe -chdir means 'change directory', but the actual feature is 'changing working directory to the current directory'.

I'm concerned some users expect vaffle#chdir('somedir') shows contents in the specified directory.

What do you think about this?

ichizok commented 6 years ago

Hmm, vaffle-cd-to-current? (ugly?)

And I changed vaffle#chdir() accepts path optional argument.

ichizok commented 6 years ago

I changed to <Plug>(vaffle-chdir-current).

ichizok commented 6 years ago

I still wonder what name is appropriate.. changed to <Plug>(vaffle-chdir-to-here).

cocopon commented 6 years ago

Sorry for the late reply, and thank you very much for your work!

ichizok commented 6 years ago

Thank you for merging 😄