search

cocopon / vaffle.vim

:file_folder: Lightweight, window-based file manager for Vim
MIT License
284 stars 20 forks source link

Add :VaffleCurrentBuffer command #16

Closed mopp closed 6 years ago

mopp commented 6 years ago

Objective

We can open a directory of a current buffer.

Drawbacks

None

cocopon commented 6 years ago

Thank you for the PR!

I think it can be replaced with :Vaffle %:h. I have a concern that adding such command leads to an increase in similar commands. (e.g. :VaffleParent, :VaffleRoot, :VaffleNextSibling, etc.)

What do you think about this?

mopp commented 6 years ago

Yes, you are right ;)

However, there are some commands which everyone would like to use many times. So, The :VaffleCurrentBuffer is a command like that, and these command should be defined in the plugin I think. of cause, it is not so easy to determine the commands because it depends on individual usage.

The following is just my opinion. Vaffle.vim is your plugin, then, you can reject this PR if you do not want. Because we have a alternative way :Vaffle %:h (and it is better to append the document)

cocopon commented 6 years ago

Thank you for sharing your opinion! I partially agree with you but the concept — Vaffle is simple — is more important thing than that, sorry.