search

cocopon / vaffle.vim

:file_folder: Lightweight, window-based file manager for Vim
MIT License
284 stars 20 forks source link

Default mappings not working #21

Closed markwu closed 5 years ago

markwu commented 6 years ago

I saw you changed the default behavior of default mappings, it just ignored the keys that already mapped by other plugins or configs.

It takes me several minutes to find this issue.

Can I have an option to force the default mappings to overwrite existing mappings?

markwu commented 6 years ago

Something like, 

let g:vaffle_force_default_mapping_overwrite = 1
(You can leave the above variable 0 to follow your recent behavior change)
cocopon commented 6 years ago

Sorry for the late reply...

Vaffle checks existence of mappings so doesn't overwrite it: https://github.com/cocopon/vaffle.vim/blob/5c16f081d88765e23ca3f740703bd0340f0ea8f3/autoload/vaffle/buffer.vim#L5

Does the problem still occur? Please tell me conflicted plugin and its mappings for reproducing the issue.

mopp commented 6 years ago

This issue may be related to the #15 .

markwu commented 6 years ago

Actually, I like your default mapping and it works very well. That's why I suggest give us an option to force the default mapping overwrite the existence global mapping in vaffle buffer.

Someone likes to overwrite, and someone does not.

For me, I like the default mapping overwrite, and I don't need to worry about which default mapping doesn't work.

cocopon commented 6 years ago

Ah, I understand the problem. Thank you for your explanation.

cocopon commented 6 years ago

After following the advice #15, I fixed the behavior of overriding the default mappings. Is the problem solved?

cocopon commented 5 years ago

Feel free to reopen the issue if you still have a problem.