[add] support for icon-font

[get-me-power]

Hello, @cocopon . Thanks for creating great Vim plugin. I wrote a patch to support vim-devicons.

vim-devicons url

https://github.com/ryanoasis/vim-devicons

This patch can rendering icon font. Could you check this PR?

screen shot

[cocopon]

Thank you for the contribution! Adding icon to each item looks nice, but there are some points that I'm concerned about.

About user interface

I think a file icon and its name should be placed side by side because they express the same subject.

• Your impl: (file icon) (selection mark) (file name)
• My thought: (selection mark) (file icon) (file name)

About implementation

Current implementation is tightly coupled with vim-devicons. If user want to use another way to show icon, we should add another renderer option and related fixes to Vaffle. I think that providing a custom function to render icon is better solution. For example:

function! RenderMyFavoriteIcon(item)
  " Use vim-devicons or other favorite way
  return ...
endfunction

let g:vaffle_render_custom_icon = 'RenderMyFavoriteIcon'

[get-me-power]

@cocopon Thanks for review! How about this patch?

example

function! RenderMyFavoriteIcon(item)
  return printf('%s %s %s',
        \ a:item.selected ? '*' : ' ',
        \ WebDevIconsGetFileTypeSymbol(a:item.basename, a:item.is_dir),
        \ a:item.basename . (a:item.is_dir ? '/' : ''))
endfunction

let g:vaffle_render_custom_icon = 'RenderMyFavoriteIcon'

If you writing this config in vimrc, vaffle can render icon font.

[cocopon]

Thanks!

• Basic design looks good
• I think that custom function should return only its icon and other UI elements (selection mark, returned icon, name) should be rendered by Vaffle for UI consistency reason
• Default value of the option should be empty because this option expects the value to be function name and string value 'default' looks like a function name

[get-me-power]

I adjusted. How about this?

example

function! RenderMyFavoriteIcon(item)
  return WebDevIconsGetFileTypeSymbol(a:item.basename, a:item.is_dir)
endfunction

let g:vaffle_render_custom_icon = 'RenderMyFavoriteIcon'

[cocopon]

Looks good! Looking into the details...

[get-me-power]

In addition, I changed the syntax highlighting. I think it will render correctly.

[get-me-power]

I updated document and syntax name.

[get-me-power]

@cocopon Thanks for review, I fixed.

[cocopon]

Great! Finally, could you squash all commits into a single one and force-push it? I'll merge it.

[get-me-power]

OK, I squashed!

[get-me-power]

@cocopon Sorry.., I fixed.

[cocopon]

Merged. Thank you for your contribution!

[get-me-power]

Thank you for your kind review and merge.