search

cocopon / vaffle.vim

:file_folder: Lightweight, window-based file manager for Vim
MIT License
284 stars 20 forks source link

use 'keepalt' when opening files for edit #57

Closed WhoIsSethDaniel closed 3 years ago

WhoIsSethDaniel commented 4 years ago

I haven't written any tests for this, yet. If this seems like something you'd want I can do it.

using keepalt is the default, but is configurable.

cocopon commented 4 years ago

First, thank you for your contribution!

Because one of Vaffle concept is "simple", so I don't want to add an option if possible. I want to consider that what is the best behavior for Vaffle before implementing the option...

roginfarrer commented 4 years ago

FWIW, I'm a fan of this change!

cocopon commented 4 years ago

After consideration, I think keepalt_on_edit = 1 is the best behavior for Vaffle . (ref: https://github.com/cocopon/vaffle.vim/issues/49#issuecomment-703020598)

Could you remove the option and make keepalt_on_edit = 1 default?

I haven't written any tests for this, yet. If this seems like something you'd want I can do it.

And could you add some test cases for this change? It clarifies the problem to be fixed.

WhoIsSethDaniel commented 4 years ago

I've pushed a new commit that includes a test and removes the option.

WhoIsSethDaniel commented 3 years ago

changes made and pushed.

cocopon commented 3 years ago

Merged! Thank you for your help.