ccMenuItem.js, ccMenuItemToggle Example Has Bad Code

cocos2d / cocos2d-html5

Cocos2d for Web Browsers. Built using JavaScript.

https://www.cocos.com

3.07k stars 902 forks source link

Closed mcscooter closed 11 years ago

mcscooter commented 11 years ago

Line 1147: * var toggler = cc.MenuItemToggle.create(this, this.callback, cc.MenuItemFont.create("On"), cc.MenuItemFont.create("Off"))

arguments are in the wrong order, should have the menuItemFont objects first:

var toggler = cc.MenuItemToggle.create( cc.MenuItemFont.create("On"), cc.MenuItemFont.create("Off"), this.callback, this)

Sorry, I didn't have time to submit a fix for this right now, maybe someone else can roll this into another change since it's just the example

mcscooter commented 11 years ago

dingpinglv commented 11 years ago

Thank you, Scott Cummings.