cocos2d / cocos2d-js

cocos2d-x for JS

http://www.cocos2d-x.org

MIT License

1.86k stars 490 forks source link

Upgrade Spine to the latest version #1381

Closed pandamicro closed 9 years ago

caiqingdong commented 9 years ago

原来代码 bool SkeletonRenderer::setAttachment (const std::string& slotName, const std::string& attachmentName) { return spSkeleton_setAttachment(_skeleton, slotName.c_str(), attachmentName.c_str()) ? true : false; }

改为

bool SkeletonRenderer::setAttachment (const std::string& slotName, const std::string& attachmentName) { return spSkeleton_setAttachment(_skeleton, slotName.c_str(), attachmentName.empty() ? nullptr : attachmentName.c_str()) ? true : false; }

原因attachment May be 0 to clear the attachment for the slot 设置slot后就不能设置隐藏

pandamicro commented 9 years ago

It have been reported here: https://github.com/cocos2d/cocos2d-x/issues/10185

pandamicro commented 9 years ago

Related PRs:

1132 #1444 #1447

We need to update SkeletonAnimation's event system in Web Engine with the same APIs in Native Engine.

It will be done in v3.4

pandamicro commented 9 years ago

1452

pandamicro commented 9 years ago

@dingpinglv Can you upgrade the SkeletonAnimation's event system API with the latest version ?

pandamicro commented 9 years ago

https://github.com/cocos2d/cocos2d-html5/pull/2758

Spine Runtime for html5 upgraded

dingpinglv commented 9 years ago

The SkeletonAnimation's event system APIs has been updated at: https://github.com/cocos2d/cocos2d-html5/pull/2772