search

cocos2d / cocos2d-js

cocos2d-x for JS
http://www.cocos2d-x.org
MIT License
1.86k stars 490 forks source link

buggy plist loader #366

Closed hbbalfred closed 10 years ago

hbbalfred commented 10 years ago

there was a bug in plist loader that read the plist file repeat both in jsb and cpp to fix it is either just read in jsb or read in cpp i have fixed in #320 to read in cpp, but @joshuastray choose another way #344 so the bug is coming again...

i have no test which way is better yet... maybe i should remove my previous modification to fix it?

pandamicro commented 10 years ago

Hi, @hbbalfred the reason we are passing file content instead of file url is that in Cocos2d-html5 we accept file content, so for compatibility, we have decided to do that. This morning, I have fixed this issue in another PR: https://github.com/cocos2d/cocos2d-js/pull/364 But after seen your PR, I noticed my solution was a little bit too complicated, so I have posted another just now: https://github.com/cocos2d/cocos2d-js/pull/367

One more thing You may have noticed that I actually reversed the refactoration to ParticleSystem's initialization, it's because it will break the CocosBuilder's ParticleSystem reader. I resolved your problem with some modification to Cocos2d-x: https://github.com/cocos2d/cocos2d-x/pull/6728

hbbalfred commented 10 years ago

nice job @pandamicro