search

cocos2d / cocos2d-x-3rd-party-libs-bin

197 stars 341 forks source link

A libflatbuffers is build inside 3rd party bins? #172

Open martell opened 9 years ago

martell commented 9 years ago

Can we move this to 3rd party source instead I have submitted a PR to google/flatbuffers with a patch to do just this you guys are welcome to use that patch in 3rd party source repo

https://github.com/google/flatbuffers/pull/238

@ricardoquesada Hi.

I'm trying to rebuild 3.7 for the new msys2 release and having source in 3rd party bins is causing issues again :D

martell commented 9 years ago

The google maintainer of the google/flatbuffers project has merged my PR. So with the next release version cocos2d-x should no longer need have a custom binary blob where as there will be an official libflatbuffers

zilongshanren commented 9 years ago

@martell Good job :+1:

ricardoquesada commented 9 years ago

+1 for moving flatbuffers to src. @minggo @pandamicro do you know why it is in bin?

pandamicro commented 9 years ago

I'm not sure why it's in bin, it's originally integrated by Beijing studio team, @chengstory @geron-cn @xiaofeng11 Maybe you guys know something ?