search

cocos2d / cocos2d-x-3rd-party-libs-bin

197 stars 340 forks source link

libuv prebuilt for windows is a debug version #353

Closed juan-medina closed 5 years ago

juan-medina commented 5 years ago

The prebuild libuv binary is a debug version, this force to any windows application created to need to have the debug runtime.

lib_uv

I was trying to see if I could do a pull request to fix it but is not clear how this works, I understand there is a project to build the dependencies but not sure if that is the case for libuv or we just add the binary.

I can add the binary but which version of libuv we are using so I do the correct one?

Thanks

minggo commented 5 years ago

Did you mean uv/prebuilt/win32/uv.dll?

juan-medina commented 5 years ago

Did you mean uv/prebuilt/win32/uv.dll?

Yes, both the win32 and win10

I've create a PR for this