is it on purpose or mistake?

cocos2d / cocos2d-x-3rd-party-libs-src

Dependencies of cocos2d-x.

142 stars 169 forks source link

is it on purpose or mistake? #144

Closed springrider closed 7 years ago

springrider commented 7 years ago

4961d9e recovered websocket header config with "websockets_header_files=l*.h ", and months later 66c86a8 reverted it...

minggo commented 7 years ago

it is on purpose, because l*.h will match unneeded header files

springrider commented 7 years ago

the current version of cocos2d-x lite has lws_config.h included. it is not necessary anymore?

minggo commented 7 years ago

it is needed, but can not just use l*.h to match it, may be should create a new issue

springrider commented 7 years ago

I am not sure why, but after change it back to "l*.h", it only copied the necessary file "lws_config.h" and "libwebsockets.h".. which is the correct behaviour...

minggo commented 7 years ago

it is because you only build websocket

springrider commented 7 years ago

right, new issue then, thanks.