search

cocos2d / cocos2d-x

Cocos2d-x is a suite of open-source, cross-platform, game-development tools utilized by millions of developers across the globe. Its core has evolved to serve as the foundation for Cocos Creator 1.x & 2.x.
https://www.cocos.com/en/cocos2d-x
18.25k stars 7.06k forks source link

Incorrect 'if' condition in js_cocos2dx_ccmat4TransformVector() #14954

Open madnut-ua opened 8 years ago

madnut-ua commented 8 years ago

In cocos2d-x-3.10\cocos\scripting\js-bindings\manual\cocos2d_specifics.cpp, 3709 in function js_cocos2dx_ccmat4TransformVector() we have the following block:

    if(argc >= 2)
    {
// some code
    }
    else if (argc >= 5)
    {
// some code
    }

It looks like there is a mistake, cause second condition won't be met at all.

zilongshanren commented 8 years ago

@madnut-ua um.. it's most likely a mistake..

zilongshanren commented 8 years ago

@pandamicro