search

cocos2d / cocos2d-x

Cocos2d-x is a suite of open-source, cross-platform, game-development tools utilized by millions of developers across the globe. Its core has evolved to serve as the foundation for Cocos Creator 1.x & 2.x.
https://www.cocos.com/en/cocos2d-x
18.25k stars 7.06k forks source link

Update CCPlatformConfig.h #20693

Closed crazyhappygame closed 3 years ago

crazyhappygame commented 3 years ago

With latest ndk23 there is no more ANDROID define. The correct way (before and now) is to use __ANDROID__ https://iq.opengenus.org/detect-operating-system-in-c/

minggo commented 3 years ago

What will happen if using lower NDK versions?

crazyhappygame commented 3 years ago

What will happen if using lower NDK versions?

Everything will work. Please check appveyor android build is green. __ANDROID__ define is the proper way to check Android platform.

BTW. Do you know what happen with Travis CI check? Only appveyor is running now.

minggo commented 3 years ago

Sorry, i don't know Travis CI issue.

crazyhappygame commented 3 years ago

@minggo could you merge it?